Improve the output of 'kops get keypairs' #11823
Conversation
k8s-ci-robot
added
size/L
|
/cc @olemarkus |
johngmyers
force-pushed
the
get-keypairs-2
branch
from
305dfa5
to
1ed3619
Compare
| }) | ||
| return t.Render(items, os.Stdout, "TYPE", "NAME", "ID") | ||
| return t.Render(items, out, "NAME", "ID", "PRIMARY", "HASPRIVATE") |
There was a problem hiding this comment.
Having notAfter here would be really nice, I think. But can be done in a follow-up.
There was a problem hiding this comment.
notBefore might be a bit more useful, given they're all ten-year certs.
There was a problem hiding this comment.
Some people still have 1.7 clusters, so may be useful someday. :)
There was a problem hiding this comment.
If we get certs rotation done gracefully, maybe an idea is to start using somewhat shorter-lived certs too.
There was a problem hiding this comment.
If root certs are being rotated then their long lifetime doesn't matter.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
No description provided.