Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set EnableExternalCloudController to true by default #11825

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

hakman
Copy link
Member

@hakman hakman commented Jun 21, 2021

This is not just about AWS, the OpenStack one for example is stable.
It means that someone should still enable the feature via spec.cloudControllerManager.cloudProvider, but no longer need to set the feature flag too.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 21, 2021
@hakman hakman requested a review from olemarkus June 21, 2021 04:41
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2021
@johngmyers
Copy link
Member

There's little point to having a feature flag then. There's no point to disabling it. The only reason to keep it would be automated tests that need to work across multiple kOps versions.

@hakman
Copy link
Member Author

hakman commented Jun 21, 2021

I thought the procedure is to set it to true in case we want to flip it back in the next few weeks at least.

@k8s-ci-robot k8s-ci-robot merged commit 2197c1a into kubernetes:master Jun 21, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 21, 2021
@hakman hakman deleted the externall_ccm_default_true branch June 21, 2021 05:24
@johngmyers
Copy link
Member

If the flag affected behavior beyond simply allowing options to be set, it would make sense to allow it to be turned back off. But this flag merely allows a field in the cluster spec to be non-nil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants