Kubetest2 fix periodic end to end tests #11838
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/test pull-kops-e2e-aws-ebs-csi-driver |
| "us-west-1a", | ||
| "us-west-1b", |
There was a problem hiding this comment.
Please just comment these same as the one below. We can live without any us-west-1.
There was a problem hiding this comment.
Is there a benefit to comment them out?
There was a problem hiding this comment.
Yes. At some point someone will wonder why there's no us-west-1 and he will add it, then remove it again.
This way maybe he reads the comment first :D.
There was a problem hiding this comment.
For me 1c exists. It probably depends on the account which one gets cut.
I'll leave this change out for now.
|
/test pull-kops-e2e-aws-ebs-csi-driver |
olemarkus
force-pushed
the
kubetest2-fix-periodics
branch
from
1de0b78
to
f49e0f8
Compare
|
/test pull-kops-e2e-aws-ebs-csi-driver |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
|
Shouldn't that test have been skipped? |
|
In the ginkgo output i see: Which doesn't exactly match the skip regex. Maybe drop the "volume.snapshot.controller" portion. |
|
I thought some of those bits were only used when pretty printing. not actually used for the regex. But apparently I was wrong there. |
No description provided.