Kubetest2 - Add --skip-regex logic #11841
Conversation
This will move the logic from build_jobs.py into kubetest2 itself. This way we can rely on this logic from scenario scripts and other places that arent directly set by build_jobs.py.
k8s-ci-robot
added
cncf-cla: yes
| if strings.Contains(cluster.Spec.KubernetesVersion, "v1.21.") { | ||
| // TODO(rifelpet): Remove once k8s tags has been created that include | ||
| // https://github.com/kubernetes/kubernetes/pull/101443 | ||
| skipRegex += "|Invalid.AWS.KMS.key" | ||
| } | ||
| if strings.Contains(cluster.Spec.KubernetesVersion, "v1.22.") { | ||
| // TODO(rifelpet): Remove once volume limits tests have been fixed | ||
| // https://github.com/kubernetes/kubernetes/issues/79660#issuecomment-854884112 | ||
| skipRegex += "|Volume.limits.should.verify.that.all.nodes.have.volume.limits" | ||
| } |
There was a problem hiding this comment.
I'm not particularly excited about this:
In build_jobs.py we have version markers that we can reference (stable, latest, etc.). kubetest2-kops takes these marker URLs, reads their contents and passes that to kops create cluster so we end up with a specific k8s version URL in the cluster spec like this.
kubetest2-tester-kops doesn't have access to the version marker being passed into kubetest2-kops, so we rely on parsing these known versions from the cluster spec instead. The potential downside is that if these k/k issues aren't fixed in 1.22, we need to remember to add v1.23 to this logic whereas in bulid_jobs.py the stable and latest markers wouldn't need any followup work. Maybe it is better to explicitly require this followup work though to ensure that these tests still need to be skipped.
Other ideas here are welcome
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This will move the logic from build_jobs.py into kubetest2 itself.
This way we can rely on this logic from scenario scripts and other places that aren't directly set by build_jobs.py.
ref: https://kubernetes.slack.com/archives/C8MKE2G5P/p1624366418361000