Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain deleted keypairs #11845

Merged
merged 2 commits into from
Jun 27, 2021
Merged

Conversation

johngmyers
Copy link
Member

@johngmyers johngmyers commented Jun 22, 2021

Keeps deleted keypairs in the store in order to prevent disasters.

Renames kops delete keypair to kops distrust keypair.

We might later create a kops trust keypair command.

/cc @olemarkus

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/api area/documentation labels Jun 22, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 24, 2021
@johngmyers johngmyers force-pushed the mark-deleted branch 6 times, most recently from 54661a4 to 48e6d8a Compare June 24, 2021 21:09
@johngmyers johngmyers changed the title WIP Retain deleted keypairs Retain deleted keypairs Jun 25, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit 61778b1 into kubernetes:master Jun 27, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 27, 2021
@johngmyers johngmyers deleted the mark-deleted branch June 27, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/office-hours lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants