Refactor etcd-client-cilium secrets #11848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
area/nodeup
area/provider/aws
johngmyers
force-pushed
the
cilium-etcd-client
branch
2 times, most recently
from
35a9737
to
eb96a67
Compare
johngmyers
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/cc @olemarkus |
|
This looks good, but I want to see if I can add an optional etcd presubmit to test this with first. |
|
/test pull-kops-e2e-cni-cilium-etcd |
2 similar comments
|
/test pull-kops-e2e-cni-cilium-etcd |
|
/test pull-kops-e2e-cni-cilium-etcd |
|
johngmyers
force-pushed
the
cilium-etcd-client
branch
from
1ed220f
to
5de6d16
Compare
|
/test pull-kops-e2e-cni-cilium-etcd |
olemarkus
approved these changes
Jun 27, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For non-kops-controller-bootstrap worker nodes, gives them a prebaked client cert/key instead of the private key of the CA.