Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #11852: Handle containerExec hooks when using containerd #11855

Conversation

hakman
Copy link
Member

@hakman hakman commented Jun 24, 2021

Cherry pick of #11852 on release-1.21.

#11852: Handle containerExec hooks when using containerd

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jun 24, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 24, 2021
@hakman
Copy link
Member Author

hakman commented Jun 24, 2021

/kind office-hours
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/office-hours labels Jun 24, 2021
@hakman hakman force-pushed the automated-cherry-pick-of-#11852-upstream-release-1.21 branch from e9c2b39 to 4d99910 Compare June 24, 2021 06:38
@hakman hakman changed the title Automated cherry pick of #11852: Pre-add hooks integration test Automated cherry pick of #11852: Handle containerExec hooks when using containerd Jun 24, 2021
@hakman
Copy link
Member Author

hakman commented Jun 24, 2021

In my opinion this should at least be part of kOps 1.21. It is also simple enough to be safe at this stage.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2021
@johngmyers
Copy link
Member

Office Hours agreed to take this in
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit 78c8a92 into kubernetes:release-1.21 Jun 24, 2021
@hakman hakman deleted the automated-cherry-pick-of-#11852-upstream-release-1.21 branch October 22, 2021 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/office-hours lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants