Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dryrun cluster creation #11863

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Conversation

johngmyers
Copy link
Member

/kind bug

A kops create cluster without a --yes fails with:

I0624 22:12:15.919463    4954 executor.go:111] Tasks: 0 done / 95 total; 43 can run
W0624 22:12:16.432849    4954 vfs_castore.go:469] CA private key was not found
I0624 22:12:17.328871    4954 executor.go:111] Tasks: 43 done / 95 total; 19 can run
W0624 22:12:18.036237    4954 executor.go:139] error running task "BootstrapScript/nodes-us-east-1b" (9m59s remaining to succeed): failed to read CA certificates: error opening resource: resource opened before it is ready (task=*fitasks.Keypair {"Name":"ca","alternateNames":null,"Lifecycle":"Sync","Signer":null,"subject":"cn=kubernetes","type":"ca","oldFormat":false})
W0624 22:12:18.036652    4954 executor.go:139] error running task "BootstrapScript/nodes-us-east-1a" (9m59s remaining to succeed): failed to read CA certificates: error opening resource: resource opened before it is ready (task=*fitasks.Keypair {"Name":"ca","alternateNames":null,"Lifecycle":"Sync","Signer":null,"subject":"cn=kubernetes","type":"ca","oldFormat":false})
W0624 22:12:18.036668    4954 executor.go:139] error running task "BootstrapScript/master-us-east-1a" (9m59s remaining to succeed): failed to read CA certificates: error opening resource: resource opened before it is ready (task=*fitasks.Keypair {"Name":"ca","alternateNames":null,"Lifecycle":"Sync","Signer":null,"subject":"cn=kubernetes","type":"ca","oldFormat":false})

This is because the Keypair task is a DefaultDeltaRunMethod() task, but is now a dependency of BootstrapScript, which is not.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 25, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2021
@k8s-ci-robot k8s-ci-robot merged commit 86afeff into kubernetes:master Jun 25, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 25, 2021
@johngmyers johngmyers deleted the keypair-dryrun branch June 25, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants