Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove version from addons #11867

Merged
merged 2 commits into from
Jun 25, 2021
Merged

Remove version from addons #11867

merged 2 commits into from
Jun 25, 2021

Conversation

hakman
Copy link
Member

@hakman hakman commented Jun 25, 2021

... as discussed and agreed during 2021.06.24 Office Hours.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 25, 2021
@hakman hakman force-pushed the remove_addon_version branch 2 times, most recently from 89c98be to d79a8cb Compare June 25, 2021 14:28
@hakman hakman changed the title [WIP] Remove version from addons Remove version from addons Jun 25, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2021
@hakman
Copy link
Member Author

hakman commented Jun 25, 2021

/cc @olemarkus @johngmyers

@hakman hakman requested a review from johngmyers June 25, 2021 16:32
@johngmyers
Copy link
Member

Oh, I have a new issue: how are we going to deal with #11776 and the need to replace instead of update for some transitions, such as changing the ports for coredns?

@hakman
Copy link
Member Author

hakman commented Jun 25, 2021

Oh, I have a new issue: how are we going to deal with #11776 and the need to replace instead of update for some transitions, such as changing the ports for coredns?

Maybe based on kOps version?

johngmyers
johngmyers approved these changes Jun 25, 2021
View reviewed changes
Copy link
Member

@johngmyers johngmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we could do it off of the Id.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2021
@k8s-ci-robot k8s-ci-robot merged commit e5185b2 into kubernetes:master Jun 25, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 25, 2021
@hakman hakman deleted the remove_addon_version branch October 22, 2021 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers approved these changes

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/channels cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hakman @johngmyers @k8s-ci-robot