Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decrease default values for net.ipv4.tcp_rmem and net.ipv4.tcp_wmem #11868

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Decrease default values for net.ipv4.tcp_rmem and net.ipv4.tcp_wmem #11868

merged 1 commit into from
Jun 25, 2021

Conversation

hakman
Copy link
Member

@hakman hakman commented Jun 25, 2021 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 25, 2021
@hakman
Copy link
Member Author

hakman commented Jun 25, 2021

/cc @rifelpet

@johngmyers
Copy link
Member

I think we should have a comment in nodeup/pkg/model/sysctls.go referencing #10206.

Also, the reference in pkg/model/bootstrapscript.go should probably be moved down to func setSysctls()

@hakman
Copy link
Member Author

hakman commented Jun 25, 2021

I think we should have a comment in nodeup/pkg/model/sysctls.go referencing #10206.
Also, the reference in pkg/model/bootstrapscript.go should probably be moved down to func setSysctls()

Added extra comments referencing #10206. Should be better now.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2021
@k8s-ci-robot k8s-ci-robot merged commit ba1e486 into kubernetes:master Jun 25, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 25, 2021
@hakman hakman deleted the experiment_sysctls branch June 25, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers approved these changes

@joshbranham joshbranham Awaiting requested review from joshbranham

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hakman @johngmyers @k8s-ci-robot