Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid spurious changes for ASG InstanceProtection and LT InstanceMonitoring #11873

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Avoid spurious changes for ASG InstanceProtection and LT InstanceMonitoring #11873

merged 1 commit into from
Jun 28, 2021

Conversation

hakman
Copy link
Member

@hakman hakman commented Jun 27, 2021 

Will modify resources:
  LaunchTemplate/master-a.masters.test.dev
  	InstanceMonitoring  	 false -> <nil>
  	...
  AutoscalingGroup/master-a.masters.test.dev
  	InstanceProtection  	 false -> <nil>
  	...

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2021
@k8s-ci-robot k8s-ci-robot added area/provider/aws Issues or PRs related to aws provider size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 27, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit 917c965 into kubernetes:master Jun 28, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 28, 2021
@hakman hakman deleted the avoid_spurious_changes branch June 28, 2021 04:37
This was referenced Jun 28, 2021
Closed
Merged
k8s-ci-robot added a commit that referenced this pull request Jul 1, 2021
@k8s-ci-robot
Merge pull request #11882 from hakman/automated-cherry-pick-of-#11873…
d6532ca 
…-upstream-release-1.21

Automated cherry pick of #11873: Avoid spurious changes for ASG InstanceProtection and LT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet approved these changes

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hakman @k8s-ci-robot @rifelpet