Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support large/slow downloads #11884

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Conversation

aojea
Copy link
Member

@aojea aojea commented Jun 28, 2021

current download code was using http.client timeout, that will
interrupt reading of the response body, breaking slow downloads
or very large files.

This patch modified the http client to detect idle downloads, and
fail after 30 seconds of innactivity. It still keeps a global
timeout of 5 minutes.

current download code was using http.client timeout, that will
interrupt reading of the response body, breaking slow downloads
or very large files.

This patch modified the http client to detect idle downloads, and
fail after 30 seconds of innactivity. It still keeps a global
timeout of 5 minutes.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 28, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 28, 2021
@aojea
Copy link
Member Author

aojea commented Jun 28, 2021

/assign @hakman @justinsb

@aojea aojea mentioned this pull request Jun 28, 2021
@hakman
Copy link
Member

hakman commented Jun 28, 2021

5 minutes is a little much. Usually when nodes are IPv4 only, it takes 1-2 seconds to download such files. Let's see how this goes.
/test pull-kops-e2e-ipv6-conformance

@aojea
Copy link
Member Author

aojea commented Jun 28, 2021

5 minutes is a little much. Usually when nodes are IPv4 only, it takes 1-2 seconds to download such files. Let's see how this goes.
/test pull-kops-e2e-ipv6-conformance

I made it configurable, just choose a random value, the point is that now we can differentiate between idle and slow connections

@hakman
Copy link
Member

hakman commented Jun 28, 2021

Cool. Thanks. 😄

@hakman
Copy link
Member

hakman commented Jun 28, 2021

Mostly ok, doing a few more runs.
/test pull-kops-e2e-ipv6-conformance

@hakman
Copy link
Member

hakman commented Jun 28, 2021

/test pull-kops-e2e-ipv6-conformance

1 similar comment
@hakman
Copy link
Member

hakman commented Jun 28, 2021

/test pull-kops-e2e-ipv6-conformance

@hakman
Copy link
Member

hakman commented Jun 28, 2021

Just perfect, thanks @aojea!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit bbe9a1a into kubernetes:master Jun 28, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 28, 2021
k8s-ci-robot added a commit that referenced this pull request Jun 30, 2021
…11886-upstream-release-1.21

Automated cherry pick of #11884: support large/slow downloads #11886: Set download timeout to 3 minutes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants