Continue if a single addon fails to be applied #11933
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a single addon fails, channels will just give up on the rest. This PR makes channels just print an error when an addon fails and continue with the next one.
Skipping on first addon failure is especially problematic with addons depending on cert-manager. These will always fail due to the missing CRDs and if these are executed before cert-manager, channels will exit and we have to hope cert-manager is executed earlier in the next iteration.