Implement some completion for "kops create cluster" #11940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
johngmyers
force-pushed
the
complete-create
branch
from
6258564
to
6afda4b
Compare
johngmyers
force-pushed
the
complete-create
branch
from
6afda4b
to
6d16c13
Compare
|
/retest |
olemarkus
approved these changes
Jul 8, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
rifelpet
reviewed
Jul 18, 2021
| completions = append(completions, "amazonvpc", "lyftvpc") | ||
| } | ||
|
|
||
| if cloudup.AlphaAllowGCE.Enabled() && (options.CloudProvider == "gce" || options.CloudProvider == "") { |
There was a problem hiding this comment.
I noticed a few odd behaviors with checking the feature flag here.
- The feature flag needs to be set prior to
kops completionevaluation rather than at the time of tab completion. I suppose this isn't a big deal since most users would have this particular feature flag set in their default shell environment. - With the feature flag set,
kops completionlogs some output that should be silenced:
export KOPS_FEATURE_FLAGS=+AlphaAllowGCE
eval $(./.build/local/kops completion zsh)
I0718 08:50:04.388774 17741 featureflag.go:167] FeatureFlag "AlphaAllowGCE"=true
There was a problem hiding this comment.
I don't think the logging behavior of kops completion changed. The old implementation didn't suppress that output either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.