Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return a clearer error when terraform is used on an unsupported provider #11953

Merged
merged 2 commits into from
Jul 19, 2021
Merged

Return a clearer error when terraform is used on an unsupported provider #11953

merged 2 commits into from
Jul 19, 2021

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented Jul 8, 2021

ref: #11951

How I determined the list of supported providers:

$ grep -rl RenderTerraform upup/pkg/fi/cloudup  | xargs -L1 dirname | uniq -c
   3 upup/pkg/fi/cloudup/spotinsttasks
  13 upup/pkg/fi/cloudup/gcetasks
  36 upup/pkg/fi/cloudup/awstasks
  16 upup/pkg/fi/cloudup/alitasks
   1 upup/pkg/fi/cloudup/dotasks

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 8, 2021
@johngmyers
Copy link
Member

It would be good to extend main.completeTarget() to only include TargetTerraform when the provider supports it. (and the same for TargetCloudformation)

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 18, 2021
@rifelpet
Copy link
Member Author

@johngmyers I added completion for create cluster but didn't touch update cluster because the cloud provider isn't in UpdateClusterOptions and I wasn't sure how to get access to the ClusterSpec from within the completion function.

@johngmyers
Copy link
Member

@rifelpet You use GetClusterForCompletion() to get access to the cluster spec.

@rifelpet rifelpet changed the title WIP Return a clearer error when terraform is used on an unsupported provider Return a clearer error when terraform is used on an unsupported provider Jul 18, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 18, 2021
johngmyers
johngmyers approved these changes Jul 19, 2021
View reviewed changes
upup/pkg/fi/cloudup/apply_cluster.go
@@ -89,6 +89,8 @@ var (
OldestSupportedKubernetesVersion = "1.17.0"
// OldestRecommendedKubernetesVersion is the oldest kubernetes version that is not deprecated in Kops
OldestRecommendedKubernetesVersion = "1.19.0"
// TerraformCloudProviders is the list of cloud providers with terraform target support
TerraformCloudProviders = []kops.CloudProviderID{kops.CloudProviderAWS, kops.CloudProviderGCE, kops.CloudProviderALI}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use a sets.String()

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 19, 2021
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@rifelpet
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2021
@rifelpet
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit be63d4f into kubernetes:master Jul 19, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers approved these changes

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

Assignees

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rifelpet @johngmyers @fejta-bot @k8s-ci-robot