Cilium etcd fixes #11961
Cilium etcd fixes #11961
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
area/addons
size/S
olemarkus
force-pushed
the
cilium-etcd-fixes
branch
from
e0a0c64
to
a536929
Compare
| etcd.Manager = &api.EtcdManagerSpec{ | ||
| Env: []api.EnvVar{ | ||
| {Name: "ETCD_AUTO_COMPACTION_MODE", Value: "revision"}, | ||
| {Name: "ETCD_AUTO_COMPACTION_RETENTION", Value: "2500"}, |
There was a problem hiding this comment.
Perhaps we should enable this for existing clusters?
There was a problem hiding this comment.
The way this is managed with env vars makes it a bit tricky. There is no way of saying "I want to manage this myself".
We could maybe highlight this more in release notes.
There was a problem hiding this comment.
We could take any value explicitly mentioned in the spec as overriding. That leaves the problem of "I want to omit this environment variable", but that has some possible solutions.
There was a problem hiding this comment.
Perhaps merge this one and cherry-pick to 1.21 and then have a longer ponder on how to set these by default for existing clusters.
There was a problem hiding this comment.
The disadvantage of that would be that clusters created in the interim would get these values set in the cluster spec, making it harder to change the defaults later. But perhaps it's an obscure enough feature.
There was a problem hiding this comment.
These defaults should be fine (same as cilium-etcd-operator used before it got deprecated). For clusters that needs something else, their cluster operators should know what to do.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Isn't periodic defragmentation necessary too ? |
|
Drefrag will just reclaim disk space. Since we use dedicated disks for etcd, it probably is not worth the cost of freezing the etcd node regularly. |
…961-origin-release-1.21 Automated cherry pick of #11961: Enable k8s event handover when kvstore is used
First commit fixes an issue where the status object of the CNP becomes too large to write to etcd. Also enables "scalability"
Second fixes #10663