Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor keysets for etcd-manager #11964

Merged
merged 10 commits into from
Jul 10, 2021
Merged

Refactor keysets for etcd-manager #11964

merged 10 commits into from
Jul 10, 2021

Conversation

johngmyers
Copy link
Member

With this I was able to gracefully rotate the etcd-manager CA certs.

Fixes a couple of bugs, most notably that CA rotation requires the new CA to have a different Subject than the old one. So I have kops create keypair put the serial number of the new CA into its Subject.

@k8s-ci-robot k8s-ci-robot added area/nodeup area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/openstack Issues or PRs related to openstack provider size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 9, 2021
@johngmyers
Copy link
Member Author

/retest

olemarkus
olemarkus requested changes Jul 10, 2021
View reviewed changes
Copy link
Member

@olemarkus olemarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit in one of the comments

nodeup/pkg/model/context.go Outdated Show resolved Hide resolved
@johngmyers @olemarkus
Fix function comment
6846ef3 
Co-authored-by: Ole Markus With <olemarkus@gmail.com>
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0bc0004 into kubernetes:master Jul 10, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 10, 2021
@johngmyers johngmyers deleted the rotate-etcd branch July 10, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus olemarkus approved these changes

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@olemarkus olemarkus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johngmyers @k8s-ci-robot @olemarkus