Unconditionally reenable KMS and Volume Limit tests #11966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes for these tests have now been released in all applicable k8s version markers
k8s-ci-robot
added
cncf-cla: yes
|
The default e2e presubmit job uses k8s 1.21 so it will confirm the KMS Key fix. This will test the volume limits fix: |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for these tests have now been released in all applicable k8s version markers
GH doesn't mention it on the commit but v1.21.2 includes the commit here. Theoretically this would fail if someone specified k8s v1.21.0 or v1.21.1 but typically we only test with the latest patch version.
GH shows it as released in v1.22.0-beta.1: kubernetes/kubernetes@164ce31