Verify CA keypair IDs for kops-controller-issued certs #11982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
johngmyers
changed the title
johngmyers
force-pushed
the
bootstrap-keypairid
branch
from
e2a33cb
to
5d0cf9a
Compare
johngmyers
changed the title
k8s-ci-robot
added
needs-rebase
johngmyers
force-pushed
the
bootstrap-keypairid
branch
from
5d0cf9a
to
10692bc
Compare
k8s-ci-robot
removed
the
needs-rebase
olemarkus
approved these changes
Jul 15, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that nodes that have kops-controller-issued certs from a demoted CA will be selected by rolling-update as needing update. If a bootstrapping node requests certs from a kops-controller that has a different idea of what the primary keypair is for one of the relevant CAs, the request will fail. This will happen after the apply_cluster following the promotion of one of the CA's keypairs. The failure will continue until whichever node (kops-controller or worker) is out of date is replaced by rolling-update.
The other possible way to do this would be to give kops-controller direct access to the secret store and allow the client node to select whichever CA keypair it wants the certs issued from.