Change set and unset commands into flags on "kops edit cluster" #11987
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
Good idea, but once this merges, many tests will have to be updated, right? |
|
Will they? I thought most tests use the |
|
Some of the scenario tests use it. But you can fix those in this PR |
|
Ah, right. So... |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold for ^^^ |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
| @@ -52,7 +52,7 @@ KOPS_B=$(kops-download-from-base) | |||
|
|
|||
| KOPS="${KOPS_B}" | |||
|
|
|||
| "${KOPS_B}" set cluster "${CLUSTER_NAME}" "cluster.spec.kubernetesVersion=${K8S_VERSION_B}" | |||
| "${KOPS_B}" edit cluster "${CLUSTER_NAME}" "--set=cluster.spec.kubernetesVersion=${K8S_VERSION_B}" | |||
There was a problem hiding this comment.
We use the master branch's scenario scripts for testing all kops versions, so this change is causing failures in kops 1.21 jobs:
There was a problem hiding this comment.
As I see it, we have three alternatives:
- Add "kops set" back in as a hidden command until we drop 1.21 as a destination for upgrade tests
- Make the script change the command based on the version of the destination kops
- Use the release branch's scenario script
No description provided.