Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue kubelet cert on apiserver nodes for k8s before 1.19 #12002

Merged
merged 1 commit into from
Jul 17, 2021

Conversation

johngmyers
Copy link
Member

@johngmyers johngmyers commented Jul 16, 2021

Fixes OpenStack and other non-kops-controller-bootstrap providers with k8s < 1.19.

Fixes #12007

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 16, 2021
@k8s-ci-robot k8s-ci-robot added area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 16, 2021
@johngmyers
Copy link
Member Author

/area provider/openstack
/kind bug

@k8s-ci-robot k8s-ci-robot added area/provider/openstack Issues or PRs related to openstack provider kind/bug Categorizes issue or PR as related to a bug. labels Jul 16, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit 86d1977 into kubernetes:master Jul 17, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 17, 2021
@johngmyers johngmyers deleted the issue-kubelet branch July 17, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nodeup: can't get certificate for kubelet on control plane and workers
3 participants