Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provision TLS server certs for controller-manager and scheduler #12030

Merged
merged 3 commits into from
Jul 24, 2021
Merged

Provision TLS server certs for controller-manager and scheduler #12030

merged 3 commits into from
Jul 24, 2021

Conversation

johngmyers
Copy link
Member

@johngmyers johngmyers commented Jul 21, 2021 •
edited
Loading

Fixes #12016

I put in an escape hatch: setting tlsCertFile: "" in the respective componentconfig will revert to the previous behavior of using a self-signed cert.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 21, 2021
@johngmyers johngmyers force-pushed the provision-certs branch 2 times, most recently from 3d3f414 to e1fce60 Compare July 21, 2021 04:51
@johngmyers johngmyers changed the title WIP Provision TLS server certs for controller-manager and scheduler Provision TLS server certs for controller-manager and scheduler Jul 23, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 23, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2021
@johngmyers
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 8e4f9d1 into kubernetes:master Jul 24, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 24, 2021
@johngmyers johngmyers deleted the provision-certs branch July 24, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet approved these changes

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

@mikesplain mikesplain Awaiting requested review from mikesplain

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/documentation area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

Provision server certificates for controller manager and scheduler
3 participants
@johngmyers @k8s-ci-robot @rifelpet