Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use regional STS endpoint #12043

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Use regional STS endpoint #12043

merged 1 commit into from
Jul 28, 2021

Conversation

johngmyers
Copy link
Member

@johngmyers johngmyers commented Jul 23, 2021 •
edited
Loading

Fixes #12042

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 23, 2021
@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label Jul 23, 2021
@johngmyers johngmyers mentioned this pull request Jul 23, 2021
Closed
@johngmyers johngmyers force-pushed the sts-region branch 2 times, most recently from f3d533a to 54bd5cb Compare July 25, 2021 04:49
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 25, 2021
@johngmyers johngmyers changed the title WIP Explicitly pass config to STS client WIP Use regional STS endpoint Jul 25, 2021
@johngmyers johngmyers changed the title WIP Use regional STS endpoint Use regional STS endpoint Jul 25, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 25, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit 81432c6 into kubernetes:master Jul 28, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 28, 2021
@johngmyers johngmyers mentioned this pull request Jul 28, 2021
Merged
@johngmyers johngmyers deleted the sts-region branch July 28, 2021 16:32
k8s-ci-robot added a commit that referenced this pull request Jul 28, 2021
@k8s-ci-robot
Merge pull request #12058 from johngmyers/automated-cherry-pick-of-#1…
71fdc7a 
…2043-upstream-release-1.21

Automated cherry pick of #12043: Use regional STS endpoint
@olemarkus olemarkus mentioned this pull request Sep 11, 2021
Closed
@justinsb justinsb mentioned this pull request Apr 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@mikesplain mikesplain Awaiting requested review from mikesplain

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

kops-controller pod not using sts vpc endpoint
3 participants
@johngmyers @k8s-ci-robot @hakman