Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull sshpubkey subcommands out of secrets #12045

Merged
merged 6 commits into from
Jul 28, 2021
Merged

Pull sshpubkey subcommands out of secrets #12045

merged 6 commits into from
Jul 28, 2021

Conversation

johngmyers
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 24, 2021
@rifelpet
Copy link
Member

This LGTM but I'm curious what the motivation is for this change

@johngmyers
Copy link
Member Author

SSH public keys are not secrets. It does not make sense to conflate them under the same subcommand. Doing so leads to a confusing CLI.

@rifelpet
Copy link
Member

rifelpet commented Jul 27, 2021 •
edited
Loading

Given that these commands are in stable Kops versions, do we need to give any sort of deprecation notice and/or support both methods for a period of time?

@johngmyers
Copy link
Member Author

The PR includes backwards compatibility interfaces. For example, the block around line 43 of create_secret.go maintains a hidden create secret sshpublickey command. Similarly, the block around line 96 of delete_secret.go maintains a hidden delete secret sshpublickey command.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit c6eb239 into kubernetes:master Jul 28, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 28, 2021
@johngmyers johngmyers deleted the sshpubkey branch July 28, 2021 02:04
@djablonski-moia djablonski-moia mentioned this pull request Dec 17, 2021
Closed
@yurrriq yurrriq mentioned this pull request Jan 3, 2022
Closed
@snovikov snovikov mentioned this pull request Dec 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet approved these changes

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

@mikesplain mikesplain Awaiting requested review from mikesplain

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation area/rolling-update cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johngmyers @rifelpet @k8s-ci-robot