-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Option to Specify OpenStack Octavia Provider #12049
Add Option to Specify OpenStack Octavia Provider #12049
Conversation
Welcome @igene! |
Hi @igene. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
607ba77
to
38ec7e6
Compare
In newer version of OpenStack, there are multiple octavia provider to choose from instead of only "octavia" as provider. This commit added a command line option "os-octavia-provider", enabling user to specify the octavia provider that will be use to create load balancers.
38ec7e6
to
7fba614
Compare
This commits adds autocomplete function for os-octavia-provider option base on the list of available providers from OpenStack document.
Looks like you need to do a |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks valid from my perspective.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zetaab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In newer version of OpenStack, there are multiple octavia provider to
choose from instead of only "octavia" as provider. This commit added a
command line option "os-octavia-provider", enabling user to specify the
octavia provider that will be use to create load balancers.