Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Debian 11 Bullseye #12108

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Conversation

ReillyBrogan
Copy link
Contributor

Add support for Debian 11 ahead of the impending release on August 14th.

Tested by creating a cluster with the debian-11-amd64-daily-20210805-725 image and verifying that both the cluster came up and that node logs did not contain any errors. Tested kubenet and cilium networking and both containerd and docker runtimes.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 5, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @ReillyBrogan!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @ReillyBrogan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 5, 2021
@k8s-ci-robot k8s-ci-robot added area/documentation area/provider/aws Issues or PRs related to aws provider labels Aug 5, 2021
@ReillyBrogan
Copy link
Contributor Author

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 5, 2021
@hakman
Copy link
Member

hakman commented Aug 5, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 5, 2021
@johngmyers
Copy link
Member

I think this deserves a release note.

Perhaps we should bake in the switch to iptables?

@hakman
Copy link
Member

hakman commented Aug 6, 2021

I think this deserves a release note.

For sure :).

Perhaps we should bake in the switch to iptables?

This is optional, works well without it too. I think most CNI plugins support it these days. It is the default in newer Ubuntu too. Probably the should be rephrased.

@ReillyBrogan
Copy link
Contributor Author

I think this deserves a release note.

For sure :).

I looked at the commit history of the releases directory, I assume PR authors are not usually expected to add those entries to their commits? (I can if that's helpful)

Perhaps we should bake in the switch to iptables?

This is optional, works well without it too. I think most CNI plugins support it these days. It is the default in newer Ubuntu too. Probably the should be rephrased.

Looks like kube-proxy supports it as of 1.17, so with the drop of 1.15 and 1.16 this release all supported versions of Kubernetes have the fix. I took a look at the various CNI plugins and the following all have auto-detection:

  • Cilium (and especially when running in kube-proxy replacement mode)
  • Weave-net
  • Flannel
  • kube-router

Calico allows configuration of the mode to be in but does not have auto-detection from what I can find.

I have no idea what the situation is with Canal with only Flannel supporting auto-detection, but I suspect you would need to manually set Calico to the correct value as well.

I was unable to find a PR or even an issue for aws-vpc or lyft-vpc, perhaps it was never an issue with those?

I think the entire section on iptables can probably be deleted from both Buster and Bullseye and perhaps moved to the Calico/Canal docs as it looks like that's the only place it's still relevant.

@hakman
Copy link
Member

hakman commented Aug 6, 2021

I agree that the iptables section can be removed from Bullseye. Buster implementation has various bugs and performance issues that were never addressed.

Calico has support for NFT and autodetection:

- name: FELIX_IPTABLESBACKEND
value: "{{- or .Networking.Calico.IptablesBackend "Auto" }}"

Canal... needs a maintainer :).
Lyft... will be removed soon.

@ReillyBrogan
Copy link
Contributor Author

I agree that the iptables section can be removed from Bullseye

This is done.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit 76727cb into kubernetes:master Aug 6, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Aug 6, 2021
@ReillyBrogan ReillyBrogan deleted the debian11 branch August 6, 2021 22:45
k8s-ci-robot added a commit that referenced this pull request Aug 13, 2021
…12130-upstream-release-1.21

Automated cherry pick of #12108: Support Debian 11 Bullseye
#12130: Debian 11: python-apt is not available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants