-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Debian 11 Bullseye #12108
Support Debian 11 Bullseye #12108
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @ReillyBrogan! |
Hi @ReillyBrogan. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I signed it |
/ok-to-test |
I think this deserves a release note. Perhaps we should bake in the switch to iptables? |
For sure :).
This is optional, works well without it too. I think most CNI plugins support it these days. It is the default in newer Ubuntu too. Probably the should be rephrased. |
I looked at the commit history of the releases directory, I assume PR authors are not usually expected to add those entries to their commits? (I can if that's helpful)
Looks like kube-proxy supports it as of 1.17, so with the drop of 1.15 and 1.16 this release all supported versions of Kubernetes have the fix. I took a look at the various CNI plugins and the following all have auto-detection:
Calico allows configuration of the mode to be in but does not have auto-detection from what I can find. I have no idea what the situation is with Canal with only Flannel supporting auto-detection, but I suspect you would need to manually set Calico to the correct value as well. I was unable to find a PR or even an issue for aws-vpc or lyft-vpc, perhaps it was never an issue with those? I think the entire section on iptables can probably be deleted from both Buster and Bullseye and perhaps moved to the Calico/Canal docs as it looks like that's the only place it's still relevant. |
I agree that the iptables section can be removed from Bullseye. Buster implementation has various bugs and performance issues that were never addressed. Calico has support for NFT and autodetection: kops/upup/models/cloudup/resources/addons/networking.projectcalico.org/k8s-1.16.yaml.template Lines 4110 to 4111 in 1d42125
Canal... needs a maintainer :). |
This is done. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add support for Debian 11 ahead of the impending release on August 14th.
Tested by creating a cluster with the
debian-11-amd64-daily-20210805-725
image and verifying that both the cluster came up and that node logs did not contain any errors. Tested kubenet and cilium networking and both containerd and docker runtimes.