Remove UseServiceAccountIAM feature flag and rename feature to UseServiceAccountExternalPermissions #12109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/addons
area/api
area/documentation
area/provider/aws
olemarkus
force-pushed
the
useserviceaccountexternalpermissions
branch
from
2ca17c0
to
0a28c46
Compare
k8s-ci-robot
removed
the
needs-rebase
olemarkus
force-pushed
the
useserviceaccountexternalpermissions
branch
from
0a28c46
to
2bebc3f
Compare
rifelpet
reviewed
Aug 6, 2021
pkg/featureflag/featureflag.go
Outdated
Comment on lines
90
to
91
| // UseServiceAccountIAM controls whether we use pod-level IAM permissions for our system pods and kOps addons. | ||
| UseServiceAccountIAM = new("UseServiceAccountIAM", Bool(false)) | ||
| UseServiceAccountIAM = new("UseServiceAccountIAM", Bool(true)) |
There was a problem hiding this comment.
grep shows that this isnt used anymore so I think we can remove it as well as from ./tests/e2e/scenarios/lib/common.sh
There was a problem hiding this comment.
Unknown feature flags are logged and otherwise ignored, so this should be removed.
olemarkus
force-pushed
the
useserviceaccountexternalpermissions
branch
from
2bebc3f
to
4b5a06d
Compare
johngmyers
requested changes
Aug 6, 2021
olemarkus
force-pushed
the
useserviceaccountexternalpermissions
branch
from
4b5a06d
to
e76c0bb
Compare
|
/retest |
olemarkus
force-pushed
the
useserviceaccountexternalpermissions
branch
from
e76c0bb
to
56e12f5
Compare
k8s-ci-robot
added
the
needs-rebase
olemarkus
force-pushed
the
useserviceaccountexternalpermissions
branch
from
56e12f5
to
94e18ad
Compare
k8s-ci-robot
removed
the
needs-rebase
olemarkus
force-pushed
the
useserviceaccountexternalpermissions
branch
from
94e18ad
to
377f549
Compare
…viceAccountExternalPermissions
olemarkus
force-pushed
the
useserviceaccountexternalpermissions
branch
from
377f549
to
0439bb0
Compare
johngmyers
approved these changes
Aug 7, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.