Openstack: add port metadata

[mitch000001]

This adds some more tags to the Openstack ports.
Specifically the previous code added the cluster name as an unkeyed tag. Now the cluster name gets added with a named tag, following the server metadata:
The cluster name is tagged by adding KubernetesCluster=cluster-name as a tag. Also, the instance group name and the stripped port name (without instance group and cluster name).

This is a preparation of enabling rolling update with surge (detaching instances) for Openstack. The goal is to be able to remove the port name which also embeds the order of the port within the instance group and to replace it with a hashed name, similar to how the servers are created.

[k8s-ci-robot]

Hi @mitch000001. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[johngmyers]

/ok-to-test
/cc @zetaab

[mitch000001]

/retest

[mitch000001]

/test pull-kops-verify-bazel

[zetaab]

@mitch000001 when we are thinking to recreate ports in rolling update. We need also check that internal certificates will work after that (in k8s). Also another problem is that bastion host in that case will be changing floatingip all the time. So we need take care that old one is deleted correctly.

I will check content of this pr tomorrow. Anyways I like the idea of detaching instances

[mitch000001]

Well, that PR is only attaching useful information to the ports for later use. I haven't looked into the issues you mentioned but thanks for the heads-up 🙂

[johngmyers]

Consider using kubernetes.io/cluster/NAME: owned instead of legacy tag names.

[zetaab]

@johngmyers the problem with openstack is that all metadata does not allow / chars and also the maximum length is quite small. I do not know what is the case with ports, maybe works maybe not

[zetaab]

for me this looks valid. However, @mitch000001 could you check comment #12122 (comment) and test can we use those tags? It might be that we cannot

[mitch000001]

So, I guess it could be possible to add that label. The problem is more that those things are really tags, so we'd use the artificial key=value.
I can try out if slashes are valid characters for tags and add them if possible.

[mitch000001]

Having said my earlier comment the main problem with tags is that they have a length limit, I think it's 60 characters, so the proposed label could be slightly too long given that it contains both key and value.

[zetaab]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/model/openstackmodel/OWNERS [zetaab]
• upup/pkg/fi/cloudup/openstack/OWNERS [zetaab]
• upup/pkg/fi/cloudup/openstacktasks/OWNERS [zetaab]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment