Fix disabling unattended upgrades #12123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
area/nodeup
size/L
olemarkus
force-pushed
the
node-unattended-upgrades
branch
from
aac2b45
to
96edba8
Compare
hakman
reviewed
Aug 9, 2021
hakman
reviewed
Aug 10, 2021
| "k8s.io/kops/upup/pkg/fi" | ||
| ) | ||
|
|
||
| func TestUpdateServiceBuilderAutomaticUpgrade(t *testing.T) { |
There was a problem hiding this comment.
Maybe split this into 2 functions?
k8s-ci-robot
added
the
lgtm
added 2 commits
August 10, 2021 12:51
Current default AMIs pre-install and pre-configure unattended upgrades. We therefor need to explicitly disable it if the update policy requires it.
olemarkus
force-pushed
the
node-unattended-upgrades
branch
from
96edba8
to
f1a8565
Compare
k8s-ci-robot
removed
the
lgtm
hakman
approved these changes
Aug 10, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added a commit
that referenced
this pull request
Aug 11, 2021
…123-origin-release-1.21 Automated cherry pick of #12123: Test if update_service behaves as intended
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current default AMIs pre-install and pre-configure unattended upgrades. We therefor need to explicitly disable it if the update policy requires it.