Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump cilium to 1.10.3 #12141

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Bump cilium to 1.10.3 #12141

merged 1 commit into from
Aug 12, 2021

Conversation

olemarkus
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 12, 2021
@olemarkus
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@olemarkus: The following commands are available to trigger required jobs:

  • /test pull-kops-e2e-k8s-ci
  • /test pull-kops-e2e-k8s-ci-ha
  • /test pull-kops-e2e-k8s-docker
  • /test pull-kops-e2e-kubernetes-aws
  • /test pull-kops-e2e-k8s-ubuntu2010
  • /test pull-kops-e2e-k8s-ubuntu2104
  • /test pull-kops-e2e-k8s-debian11
  • /test pull-kops-e2e-k8s-gce
  • /test pull-kops-e2e-aws-cloud-controller-manager
  • /test pull-kops-e2e-aws-cloud-controller-manager-irsa
  • /test pull-kops-e2e-aws-irsa
  • /test pull-kops-e2e-ipv6-conformance
  • /test pull-kops-e2e-aws-ebs-csi-driver
  • /test pull-kops-e2e-aws-ebs-csi-driver-irsa
  • /test pull-e2e-kops-aws-load-balancer-controller
  • /test pull-e2e-kops-addon-resource-tracking
  • /test pull-kops-e2e-cni-amazonvpc
  • /test pull-kops-e2e-cni-calico
  • /test pull-kops-e2e-cni-canal
  • /test pull-kops-e2e-cni-cilium
  • /test pull-kops-e2e-cni-cilium-etcd
  • /test pull-kops-e2e-cni-flannel
  • /test pull-kops-e2e-cni-kuberouter
  • /test pull-kops-e2e-cni-weave
  • /test pull-kops-bazel-build
  • /test pull-kops-bazel-test
  • /test pull-kops-e2e-kubernetes-do-kubetest2
  • /test pull-kops-verify-bazel
  • /test pull-kops-verify-generated
  • /test pull-kops-verify-gomod
  • /test pull-kops-verify-boilerplate
  • /test pull-kops-verify-gofmt
  • /test pull-kops-verify-govet
  • /test pull-kops-verify-staticcheck
  • /test pull-kops-verify-hashes
  • /test pull-kops-verify-terraform
  • /test pull-kops-verify-cloudformation

Use /test all to run the following jobs that were automatically triggered:

  • pull-kops-e2e-kubernetes-aws
  • pull-kops-e2e-cni-cilium
  • pull-kops-bazel-build
  • pull-kops-bazel-test
  • pull-kops-verify-bazel
  • pull-kops-verify-generated
  • pull-kops-verify-gomod
  • pull-kops-verify-boilerplate
  • pull-kops-verify-gofmt
  • pull-kops-verify-govet
  • pull-kops-verify-staticcheck
  • pull-kops-verify-terraform
  • pull-kops-verify-cloudformation

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@olemarkus
Copy link
Member Author

/test pull-kops-e2e-cni-cilium
/test pull-kops-e2e-cni-cilium-etcd

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 12, 2021
@olemarkus olemarkus mentioned this pull request Aug 12, 2021
Closed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit b1e6064 into kubernetes:master Aug 12, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Aug 12, 2021
@olemarkus olemarkus changed the title Bump cilium to 1.10.3 Bump cilium and add manifest support for 1.9.9 and 1.10.3 Aug 13, 2021
@olemarkus olemarkus changed the title Bump cilium and add manifest support for 1.9.9 and 1.10.3 Bump cilium to 1.10.3 Aug 13, 2021
rifelpet
rifelpet reviewed Sep 23, 2021
View reviewed changes
...s_s3_bucket_object_minimal-warmpool.example.com-addons-networking.cilium.io-k8s-1.16_content
Comment on lines +535 to +538
- hostPath:
path: /sys/fs/cgroup/unified
type: DirectoryOrCreate
name: cilium-cgroup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olemarkus this change caused all cilium + rhel8 jobs to fail

https://testgrid.k8s.io/kops-grid#kops-grid-cilium-rhel8-k22-containerd

kubelet logs report:

E0916 00:19:04.290207 18754 nestedpendingoperations.go:301] Operation for "{volumeName:kubernetes.io/host-path/23431797-5c17-4404-b61b-33d2e8ec3d54-cilium-cgroup podName:23431797-5c17-4404-b61b-33d2e8ec3d54 nodeName:}" failed. No retries permitted until 2021-09-16 00:19:36.290185341 +0000 UTC m=+151.386939478 (durationBeforeRetry 32s). Error: MountVolume.SetUp failed for volume "cilium-cgroup" (UniqueName: "kubernetes.io/host-path/23431797-5c17-4404-b61b-33d2e8ec3d54-cilium-cgroup") pod "cilium-8rdpr" (UID: "23431797-5c17-4404-b61b-33d2e8ec3d54") : mkdir /sys/fs/cgroup/unified: read-only file system

I dont see any reference to /sys/fs/cgroup/unified in the cilium repo, do you know where this value came from? I'm debating if we want to try to fix this or if we just stop testing cilium + rhel8.

/cc @hakman

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cilium's approach to this is to mount cgroup2 on /sys/fs/cilium-cgroup or something like that, and use that.
But "all modern distros" mount cgroup2 /sys/fs/cgroup, so I simplified things by just assuming it exists.

I overestimated the modernness of redhat and AL2 though.
We could mount cgroup2 explicitly somewhere else as well, like we used to with bpffs. Or we could drop support for not-that-modern-distros.

@rifelpet rifelpet mentioned this pull request Sep 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet left review comments

@johngmyers johngmyers johngmyers approved these changes

@hakman hakman Awaiting requested review from hakman

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@olemarkus @k8s-ci-robot @rifelpet @johngmyers