-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
leverage proxy env variables #12150
leverage proxy env variables #12150
Conversation
@aojea: GitHub didn't allow me to request PR reviews from the following users: ep4sh. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aojea! :)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @aojea ! ^^ 👍🏻 |
…-upstream-release-1.21 Automated cherry pick of #12150: leverage proxy env variables
The default http transport uses the proxy if the proxy environment variables exist.
However, since we are creating a new transport to define our own timeout, we should set that proxy option.
https://pkg.go.dev/net/http#DefaultTransport
Fixes: #12140