Script for iterating development on GCE #12169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
zetaab
reviewed
Aug 18, 2021
| gsutil ls "${KOPS_STATE_STORE}" || gsutil mb "${KOPS_STATE_STORE}" || return | ||
|
|
||
| # Set feature flags needed on GCE | ||
| export KOPS_FEATURE_FLAGS=AlphaAllowGCE |
There was a problem hiding this comment.
Yes, but I'd like to fix that :-)
johngmyers
reviewed
Aug 23, 2021
hack/dev-build-gce.sh
Outdated
| UPLOAD_DEST_BUCKET="kops-dev-$(gcloud config get-value project)-${USER}" | ||
| export UPLOAD_DEST=gs://${UPLOAD_DEST_BUCKET} | ||
| gsutil ls "${UPLOAD_DEST}" || gsutil mb "${UPLOAD_DEST}" || return | ||
| make kops-install dev-upload || return |
There was a problem hiding this comment.
I find using dev-upload-linux-amd64 saves a lot of time. dev-upload will rebuild and re-upload from scratch on every run.
There was a problem hiding this comment.
Good tip - changed, and also made sure to set KOPS_ARCH to only be amd64.
AWS one to follow!
johngmyers
approved these changes
Aug 24, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS one to follow!