-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate statements in control plane IAM role #12183
Conversation
3e8556d
to
c6c6387
Compare
|
||
Condition: Condition{ | ||
"StringEquals": map[string]string{ | ||
"aws:RequestTag/KubernetesCluster": p.clusterName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plan was to put all the create-like statements into a separate set and apply this condition. Removing the tag-on-create condition is perhaps less than ideal.
Thanks for picking this one up. I have been meaning to sort out the create stuff too, just that other things got in the way. As mentioned in the comments, I'd like to consolidate those into a separate set that then applies the |
c6c6387
to
3db20be
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
This reduces the policy size by ~9%
/cc @olemarkus