Add terraform outputs for OIDC provider ARN and issuer #12197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These fields are valuable because their fields are used in the assume role policies of service account IAM roles, based on the docs here: https://docs.aws.amazon.com/eks/latest/userguide/create-service-account-iam-policy-and-role.html#aws-cli
k8s-ci-robot
added
the
cncf-cla: yes
rifelpet
changed the title
k8s-ci-robot
added
the
size/M
olemarkus
approved these changes
Aug 24, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fields are valuable because their fields are used in the assume role policies of service account IAM roles, based on the docs here. This allows terraform users to pass these directly to their IAM role definitions.
The reason I'm using a hard-coded string for the issuer is because the provider doesn't output the issuer without a protocol (see docs here). The other option would be using a terraform
replace()function but we don't have support for rendering multi-argument function calls yet.