Fix terraform output for cluster names that begin with a digit

[rifelpet]

This will fail until we address each resource type generating terraform resource names that are purely the cluster name

This now includes a proposed fix.

Release notes will need to mention something along the lines of:

terraform state mv aws_iam_openid_connect_provider.123-example-com aws_iam_openid_connect_provider.provider-123-example-com
terraform state mv aws_internet_gateway.123-example-com aws_internet_gateway.gateway-123-example-com
terraform state mv aws_route_table.123-example-com aws_route_table.table-123-example-com
terraform state mv aws_vpc.123-example-com aws_vpc.vpc-123-example-com
terraform state mv aws_vpc_dhcp_options.123-example-com aws_vpc_dhcp_options.options-123-example-com
terraform state mv aws_vpc_dhcp_options_association.123-example-com aws_vpc_dhcp_options_association.association-123-example-com

I left off the s3 managed files because they're still under feature flag, though terraform may require a second terraform apply to get them into a consistent state (race conditions with the same objects being deleted by the old name and created by the new name)

fixes: #12199

[johngmyers]

Why not simply use a fixed prefix instead of something derived from the resource type?

In any case, this can conflict with clusters whose name matches, modulo one of the used prefixes. Perhaps we can use prefix_ instead of prefix-?

[rifelpet]

I will update this to use the literal prefix_ instead of resource types

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [johngmyers]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment