Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check does iface has associations #12232

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

zetaab
Copy link
Member

@zetaab zetaab commented Aug 31, 2021

fixes #12231

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 31, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5f7b4d7 into kubernetes:master Aug 31, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Aug 31, 2021
@zetaab zetaab deleted the checknilinterface branch August 31, 2021 12:58
@ArchangelX360
Copy link

Is this planned to be released in a v1.22-beta.2 by any chance?

k8s-ci-robot added a commit that referenced this pull request Aug 31, 2021
…-origin-release-1.22

Automated cherry pick of #12232: check does iface has associations
@olemarkus
Copy link
Member

Yes, it has been merged into the 1.22 branch.

@ArchangelX360
Copy link

Awesome! Do you have an ETA on the release of a 1.22.0-beta.2 by any chance? We are benchmarking something on our end so it would be awesome to have a 1.22 cluster up and ready :D!

@olemarkus
Copy link
Member

Well .. you can always do something like

export KOPS_BASE_URL="$(curl -s https://storage.googleapis.com/k8s-staging-kops/kops/releases/markers/release-1.22/latest-ci.txt)
wget "$KOPS_BASE_URL/$(go env GOOS)/$(go env GOARCH)/kops"
./kops create ...

@ArchangelX360
Copy link

Oh indeed, that would do to unblock my testing while I wait patiently for the stable release. Thanks for the tip ☺️!

@ArchangelX360
Copy link

I get:

Error: cannot determine hash for "https://artifacts.k8s.io/binaries/kops/1.22.0-beta.2+v1.22.0-beta.1-113-g63f1d9490c/linux/amd64/nodeup" (have you specified a valid file location?)

I suppose some assets are not published by the CI run so the workaround does not work?
Or am I doing something wrong?

@olemarkus
Copy link
Member

That nodeup url looks wrong. It should be

https://storage.googleapis.com/k8s-staging-kops/kops/releases/1.22.0-beta.2+v1.22.0-beta.1-113-g63f1d9490c/linux/amd64/nodeup

@johngmyers johngmyers modified the milestones: v1.22, v1.23 Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nodeup crashes in kops 1.22 beta 1 in debian 11
5 participants