Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External dns fixes #12288

Merged
merged 2 commits into from Sep 8, 2021
Merged

External dns fixes #12288

merged 2 commits into from Sep 8, 2021

Conversation

olemarkus
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 7, 2021
@olemarkus
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@olemarkus: The following commands are available to trigger required jobs:

  • /test pull-kops-e2e-k8s-ci
  • /test pull-kops-e2e-k8s-ci-ha
  • /test pull-kops-e2e-k8s-docker
  • /test pull-kops-e2e-kubernetes-aws
  • /test pull-kops-e2e-k8s-ubuntu2010
  • /test pull-kops-e2e-k8s-ubuntu2104
  • /test pull-kops-e2e-k8s-debian11
  • /test pull-kops-e2e-k8s-gce
  • /test pull-kops-e2e-aws-cloud-controller-manager
  • /test pull-kops-e2e-aws-cloud-controller-manager-irsa
  • /test pull-kops-e2e-aws-irsa
  • /test pull-kops-e2e-ipv6-conformance
  • /test pull-kops-e2e-aws-ebs-csi-driver
  • /test pull-kops-e2e-aws-ebs-csi-driver-irsa
  • /test pull-e2e-kops-aws-load-balancer-controller
  • /test pull-e2e-kops-addon-resource-tracking
  • /test pull-e2e-kops-metrics-server
  • /test pull-kops-e2e-aws-external-dns
  • /test pull-kops-e2e-aws-external-dns-irsa
  • /test pull-kops-e2e-cni-amazonvpc
  • /test pull-kops-e2e-cni-calico
  • /test pull-kops-e2e-cni-canal
  • /test pull-kops-e2e-cni-cilium
  • /test pull-kops-e2e-cni-cilium-etcd
  • /test pull-kops-e2e-cni-flannel
  • /test pull-kops-e2e-cni-kuberouter
  • /test pull-kops-e2e-cni-weave
  • /test pull-kops-bazel-build
  • /test pull-kops-bazel-test
  • /test pull-kops-e2e-kubernetes-do-kubetest2
  • /test pull-kops-verify-bazel
  • /test pull-kops-verify-generated
  • /test pull-kops-verify-gomod
  • /test pull-kops-verify-boilerplate
  • /test pull-kops-verify-gofmt
  • /test pull-kops-verify-govet
  • /test pull-kops-verify-staticcheck
  • /test pull-kops-verify-hashes
  • /test pull-kops-verify-terraform
  • /test pull-kops-verify-cloudformation

Use /test all to run the following jobs that were automatically triggered:

  • pull-kops-e2e-kubernetes-aws
  • pull-kops-bazel-build
  • pull-kops-bazel-test
  • pull-kops-verify-bazel
  • pull-kops-verify-generated
  • pull-kops-verify-gomod
  • pull-kops-verify-boilerplate
  • pull-kops-verify-gofmt
  • pull-kops-verify-govet
  • pull-kops-verify-staticcheck

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@olemarkus
Copy link
Member Author

/test pull-kops-e2e-aws-external-dns

rifelpet
rifelpet approved these changes Sep 7, 2021
View reviewed changes
docs/cluster_spec.md
```

Note that you if you have dns-controller installed, you need to remove this deployment before updating the cluster with the new configuration.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use our pruning support to delete it instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When/if it merges :)

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 7, 2021
@olemarkus
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot added area/addons and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 7, 2021
@olemarkus
Copy link
Member Author

/test pull-kops-e2e-aws-external-dns

@olemarkus
Copy link
Member Author

/test pull-kops-e2e-aws-external-dns

@olemarkus olemarkus force-pushed the external-dns-fixes branch 2 times, most recently from 817a6d4 to 429d7b5 Compare September 8, 2021 09:45
@olemarkus
Copy link
Member Author

/test pull-kops-e2e-aws-external-dns

@olemarkus
Copy link
Member Author

/test pull-kops-e2e-aws-external-dns

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d69106e into kubernetes:master Sep 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Sep 8, 2021
@olemarkus olemarkus mentioned this pull request Sep 11, 2021
Merged
k8s-ci-robot added a commit that referenced this pull request Sep 11, 2021
@k8s-ci-robot
Merge pull request #12301 from olemarkus/automated-cherry-pick-of-#12…
fa83129 
…289-#12288-origin-release-1.22

Automated cherry pick of #12289: Include kops- prefix in external-dns TXT record
#12288: Fix docs for external-dns provider
@johngmyers johngmyers modified the milestones: v1.22, v1.23 Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet approved these changes

@hakman hakman Awaiting requested review from hakman

@joshbranham joshbranham Awaiting requested review from joshbranham

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@olemarkus @k8s-ci-robot @rifelpet @johngmyers