Deprecate TerraformJSON feature flag #12341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/documentation
needs-rebase
The FF is deprecated and would require a lot of effort to support disabling TerraformManagedFiles (which is required) in this one integration test case
rifelpet
force-pushed
the
managed-files3
branch
from
93f6a19
to
3cc7162
Compare
k8s-ci-robot
removed
the
needs-rebase
hakman
approved these changes
Sep 17, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 18, 2021
…41-origin-release-1.22 Automated cherry pick of #12341: Disallow TerraformJSON + TerraformManagedFiles and
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks out portions of #12322 into separate PRs. Terraform's JSON support doesn't support provider aliases which means we cant use TerraformManagedFiles with it. This PR adds an error check ensuring they aren't used concurrently.
Given that we intend to eventually enable TerraformManagedFiles unconditionally and that TerraformJSON was implemented as a stop-gap until we had native HCL2 support for Terraform 0.12, it makes more sense to deprecate and eventually remove the TerraformJSON feature flag.
This also removes the TerraformJSON integration test. The test would need to disable TerraformManagedFiles which is pretty invasive to our integration test setup (the
expectedFileNameswould need to exclude all of theaws_s3_bucket_objects) . Given that its deprecated and would be the only reason for such complexity, I opted to just remove the test altogether.