Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove unneeded network related sysctls" #12415

Merged
merged 1 commit into from
Sep 25, 2021

Conversation

olemarkus
Copy link
Member

This reverts commit ce08ec6.

Removing these sysctls broke a number of CNIs (weave, aws vpc, and canal), and possibly breaks configurations we do not test as well.

The accept_ra sysctls can be removed in a followup.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 25, 2021
@olemarkus
Copy link
Member Author

/test pull-kops-e2e-cni-weave

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8225c78 into kubernetes:master Sep 25, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 25, 2021
@hakman
Copy link
Member

hakman commented Sep 25, 2021

Any idea why those things broke? Canal is unmaintained at the moment.

k8s-ci-robot added a commit that referenced this pull request Sep 25, 2021
…415-origin-release-1.22

Automated cherry pick of #12415: Revert "Remove unneeded network related sysctls"
@olemarkus
Copy link
Member Author

Most likely the other CNIs set forwarding if not already set. Both Cilium and Calico at least depend on forwarding happening on kernel level when not running in BPF mode. Weave documentation explicitly says it expects forwarding to be enabled outside of the CNI.

@hakman
Copy link
Member

hakman commented Sep 25, 2021

In this case you could have just added IPv4 forwarding instead of reverting the whole thing and adding back the accept_ra mess.

@kubernetes kubernetes deleted a comment Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants