Add fixed version to all addons #12416
Conversation
k8s-ci-robot
added
cncf-cla: yes
| @@ -105,6 +105,11 @@ func (b *BootstrapChannelBuilder) Build(c *fi.ModelBuilderContext) error { | |||
| } | |||
|
|
|||
| for _, a := range addons.Spec.Addons { | |||
| // Older versions of channels that may be running on the upgrading cluster requires Version to be set | |||
| // We hardcode version to a high version to ensure an update is triggered on first run, and from then on | |||
| // only a hash change will trigger an addon update. | |||
There was a problem hiding this comment.
Consider mentioning "This can be removed when kops no longer supports k8s 1.22"
There was a problem hiding this comment.
Unfortunately this follows kops versioning and we don't have any skew/upgrade jump policy. This will have to remain forever unless we change this
We need to set a version that is at least as high as the old addon versions. That is 4.0.0, I think. If we don't none of these addons will be updated. |
My understanding is that they will be updated once new control-plane nodes are started, we just need the kOps ones (like kops-controller) to be updated before that. |
k8s-ci-robot
added
the
needs-rebase
This will make also older channels trigger addon updates
This will prevent an old kops-controller pod from being scheduled to the new master.
olemarkus
force-pushed
the
channel-versions
branch
from
35bf523
to
d1ff109
Compare
k8s-ci-robot
removed
the
needs-rebase
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
…416-origin-release-1.22 Automated cherry pick of #12416: Add fixed version to all addons
This should ensure addon updates are triggered before rolling the cluster, as expected.
We also update addons before labeling masters to ensure that kops-controller is updated before it is scheduled.
Should hopefully fix #12249
/cc @zetaab