protokube: don't try to connect to apiserver if not control-plane #12424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We run protokube on the nodes in gossip mode; however protokube tries to connect to the apiserver on localhost, and that simply won't work if running on a node. This doesn't cause any actual problems beyond logspam, but it's an easy fix.
k8s-ci-robot
added
size/S
hakman
approved these changes
Sep 26, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
k8s-ci-robot
added a commit
that referenced
this pull request
Oct 5, 2021
…24-origin-release-1.22 Automated cherry pick of #12424: protokube: don't try to connect to apiserver if not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run protokube on the nodes in gossip mode; however protokube tries
to connect to the apiserver on localhost, and that simply won't work
if running on a node.
This doesn't cause any actual problems beyond logspam, but it's an
easy fix.