Make it possible to set CAS max-node-provision-time #12437
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/retest |
pkg/apis/kops/componentconfig.go
Outdated
| @@ -992,6 +992,8 @@ type ClusterAutoscalerConfig struct { | |||
| // CPURequest of cluster autoscaler container. | |||
| // Default: 100m | |||
| CPURequest *resource.Quantity `json:"cpuRequest,omitempty"` | |||
| // MaxNodeProvisionTime determines how long CAS will wait for a node to join the cluster. | |||
| MaxNodeProvisionTime *string `json:"maxNodeProvisionTime,omitempty"` | |||
There was a problem hiding this comment.
Why is this a pointer? What is the utility of setting this to the empty string?
There was a problem hiding this comment.
I suppose that is the case for many of the above. Empty string and nil would mean the same.
Do you want to change this to non-pointer if we prefer that?
k8s-ci-robot
added
the
needs-rebase
|
@olemarkus: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
removed
the
needs-rebase
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
…437-origin-release-1.22 Automated cherry pick of #12437: Make it possible to set CAS max-node-provision-time
No description provided.