Truncate cluster name in NTH EventBridgeRules #12439
Conversation
k8s-ci-robot
added
size/XL
| name = "nthsqsresources.example.com-ASGLifecycle" | ||
| resource "aws_cloudwatch_event_rule" "nthsqsresources-longclustername-e-fkbaoh-ASGLifecycle" { | ||
| event_pattern = file("${path.module}/data/aws_cloudwatch_event_rule_nthsqsresources.longclustername.e-fkbaoh-ASGLifecycle_event_pattern") | ||
| name = "nthsqsresources.longclustername.e-fkbaoh-ASGLifecycle" |
There was a problem hiding this comment.
here's the relevant change in the integration test
rifelpet
force-pushed
the
nth-truncate
branch
from
ed05eb9
to
88112e4
Compare
k8s-ci-robot
added
size/XXL
rifelpet
force-pushed
the
nth-truncate
branch
from
88112e4
to
3311e45
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
…39-origin-release-1.22 Automated cherry pick of #12439: Lengthen NTH integration test cluster name
…39-origin-release-1.21 Automated cherry pick of #12439: Lengthen NTH integration test cluster name
|
@rifelpet - Thanks for this fix, any idea when there will be a re-release of kops 1.21 including this fix? - we've ended up in the unenviable situation where some of our cluster estate has upgraded to 1.21 and some has hit this cluster hostname length issue and is stuck on 1.20 (we turned on the eventbridge stuff during our upgrade).. |
|
@BenWolstencroft v1.21.2 was just released which includes this fix. |
ref: #12329
alternative to #12330
This truncates them with a random suffix and uses that shortened name in both the creation and deletion of event bridge rules. This should fix EventBridgeRule creation on clusters with long names.