Replace klog flags with go-runner in k8s 1.23 #12494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
johngmyers
approved these changes
Oct 7, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
jaxesn
added a commit
to jaxesn/eks-distro
that referenced
this pull request
May 13, 2022
For 1.23 clusters kops changed the static pod manifests to run /go-runner instead of relying on the entry point set in the dockerfile. go-runner has been at the / of the upstream container for many versions now. This should continue to work with previous versions as well Kops PR: kubernetes/kops#12494
eks-distro-bot
pushed a commit
to aws/eks-distro
that referenced
this pull request
May 13, 2022
For 1.23 clusters kops changed the static pod manifests to run /go-runner instead of relying on the entry point set in the dockerfile. go-runner has been at the / of the upstream container for many versions now. This should continue to work with previous versions as well Kops PR: kubernetes/kops#12494
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These flags have been deprecated, see https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/2845-deprecate-klog-specific-flags-in-k8s-components
Also observe the deprecation warnings currently emitted in our 1.23 prow jobs: https://storage.googleapis.com/kubernetes-jenkins/logs/e2e-kops-grid-scenario-ipv6-conformance/1445295102216900608/artifacts/cluster-info/kube-system/kube-scheduler-ip-172-20-61-191.eu-west-1.compute.internal/logs.txt