-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCE: support egress specification #12600
Conversation
@justinsb overall looks good, please fix the terraform part and good to go
|
@@ -188,6 +226,12 @@ func (*Router) RenderTerraform(t *terraform.TerraformTarget, a, e, changes *Rout | |||
NATIPAllocateOption: e.NATIPAllocationOption, | |||
SourceSubnetworkIPRangesToNat: e.SourceSubnetworkIPRangesToNAT, | |||
} | |||
for _, subnet := range e.Subnetworks { | |||
trn.Subnetworks = append(trn.Subnetworks, &terraformRouterNatSubnetwork{ | |||
Name: subnet.TerraformLink(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name: subnet.TerraformLink(), | |
Name: subnet.TerraformName(), |
kops/upup/pkg/fi/cloudup/gcetasks/subnet.go
Lines 238 to 240 in bfaee4e
func (i *Subnet) TerraformName() *terraformWriter.Literal { | |
return terraformWriter.LiteralProperty("google_compute_subnetwork", *i.Name, "name") | |
} |
Empty or "nat" now defaults to creating a per-subnet NAT router for private topologies. "external" will assume that egress is configured outside of kOps.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
prow job pod timeout :( /retest |
I wonder if the pod is being OOMkilled. the job doesn't have a memory limit in place /retest |
Empty or "nat" now defaults to creating a per-subnet NAT router for
private topologies. "external" will assume that egress is configured
outside of kOps.
Issue #12563