Upgrade external-dns to 0.10.1 for Kubernetes >= 1.19 #12724
Conversation
k8s-ci-robot
added
cncf-cla: yes
johngmyers
force-pushed
the
external-dns
branch
from
b78cdaf
to
6417d75
Compare
|
/test pull-kops-e2e-aws-external-dns |
upup/pkg/fi/cloudup/bootstrapchannelbuilder/bootstrapchannelbuilder.go
Outdated
Show resolved
Hide resolved
|
/test pull-kops-e2e-aws-external-dns |
|
The IRSA e2e test will hopefully be fixed by kubernetes/test-infra#24341 |
johngmyers
force-pushed
the
external-dns
branch
from
6417d75
to
046bd07
Compare
|
/test pull-kops-e2e-aws-external-dns |
| requests: | ||
| cpu: 50m | ||
| memory: 50Mi | ||
| --- |
There was a problem hiding this comment.
What is this service used for?
There was a problem hiding this comment.
I believe it is for pulling metrics
There was a problem hiding this comment.
Do we want to expose this? Usually we don't add services just for metrics as it is not given this is the way users want to scrape metrics.
There was a problem hiding this comment.
The upstream chart unconditionally creates this service.
There was a problem hiding this comment.
Upstream does not always do the right thing though. but well .. it's in now anyway.
johngmyers
force-pushed
the
external-dns
branch
from
046bd07
to
8c8455b
Compare
|
/test pull-kops-e2e-aws-external-dns-irsa |
1 similar comment
|
/test pull-kops-e2e-aws-external-dns-irsa |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
…2724-upstream-release-1.22 Automated cherry pick of #12724: Upgrade external-dns to 0.10.1 for Kubernetes >= 1.19
/cc @rifelpet