Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create cluster flag for enabling IRSA #12741

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

johngmyers
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 14, 2021
@johngmyers johngmyers force-pushed the discovery-store branch 2 times, most recently from c391549 to ee8999f Compare November 14, 2021 21:39
@hakman
Copy link
Member

hakman commented Nov 15, 2021

/cc @olemarkus
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 93abe32 into kubernetes:master Nov 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 15, 2021
@hakman
Copy link
Member

hakman commented Nov 15, 2021

@johngmyers @olemarkus Should we cherry-pick this to 1.22 to make things easier for users?

@johngmyers johngmyers deleted the discovery-store branch November 15, 2021 16:16
@johngmyers
Copy link
Member Author

I think that would be something to bring up in Office Hours. This is a release-noteable feature, but it would make things much easier.

k8s-ci-robot added a commit that referenced this pull request Nov 19, 2021
…-upstream-release-1.22

Automated cherry pick of #12741: Add create cluster flag for enabling IRSA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants