Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCE: Support kops-controller, including in gossip mode #12742

Merged
merged 1 commit into from
Dec 4, 2021
Merged

GCE: Support kops-controller, including in gossip mode #12742

merged 1 commit into from
Dec 4, 2021

Conversation

justinsb
Copy link
Member

We discover the kops-controller in gossip mode using seeding code that
calls into the GCE API, just like gossip itself does.

We refactor the gossip code into a shared gcediscovery library with
minimal dependencies.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 14, 2021
@johngmyers
Copy link
Member

Bootstrap changes look good. I don't know about the other GCE-specific changes.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2021
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 2, 2021
@justinsb
Copy link
Member Author

justinsb commented Dec 2, 2021

/test pull-kops-e2e-k8s-gce
/test pull-kops-e2e-k8s-gce-calico-u2004-k22-containerd

@justinsb
Copy link
Member Author

justinsb commented Dec 2, 2021

The GCE PR jobs are green 🎉

@justinsb
Copy link
Member Author

justinsb commented Dec 2, 2021

/test pull-kops-e2e-cni-cilium-ipv6
/test pull-kops-e2e-cni-calico-ipv6

Not quite sure how these got triggered, but they should be unrelated / should pass!

@johngmyers
Copy link
Member

@justinsb I added the IPv6 jobs to trigger for PRs that affect files for the corresponding CNIs. They might require the PR to be rebased to take in recent IPv6 changes.

@johngmyers
Copy link
Member

/test pull-kops-e2e-cni-cilium-ipv6

@k8s-ci-robot
Copy link
Contributor

@justinsb: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-cni-cilium-ipv6 1312bc5 link true /test pull-kops-e2e-cni-cilium-ipv6

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rifelpet
rifelpet reviewed Dec 3, 2021
View reviewed changes
upup/pkg/fi/cloudup/gce/gcediscovery/resolver.go
var requiredTags []string

// We assume we are trying to resolve a component that runs on the control plane
requiredTags = append(requiredTags, gce.TagForRole(r.clusterName, kops.InstanceGroupRoleMaster))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also find instances tagged with InstanceGroupRoleAPIServer?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know; but here's why I think we don't need to do it yet..

  1. We don't need all the candidates, we just want to find one we can connect to
  2. Do we run kops-controller on apiserver only nodes? (And will we continue to do?)

@justinsb
GCE: Support kops-controller, including in gossip mode
4cf52d0 
We discover the kops-controller in gossip mode using seeding code that
calls into the GCE API, just like gossip itself does.

We refactor the gossip code into a shared gcediscovery library with
minimal dependencies.
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit ed6bbc7 into kubernetes:master Dec 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet approved these changes

@hakman hakman Awaiting requested review from hakman

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/office-hours lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justinsb @johngmyers @k8s-ci-robot @rifelpet