Stable-sort subnets by Name #12780
Merged
Stable-sort subnets by Name #12780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures a stable order, even if/when the IDs aren't set (e.g. in terraform)
k8s-ci-robot
added
do-not-merge/work-in-progress
|
I observed a test-failure here, where it looks like we are not stable-sorting subnet mappings: https://github.com/kubernetes/kops/runs/4253856935?check_suite_focus=true I think the root cause is that only the Name is set in terraform. |
hakman
approved these changes
Nov 18, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
justinsb
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
OK, as this issue is blocking other PRs, removing WIP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures a stable order, even if/when the IDs aren't set (e.g. in terraform)