Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action for automatically tagging releases #12805

Merged
merged 1 commit into from
Jan 1, 2022

Conversation

johngmyers
Copy link
Member

@johngmyers johngmyers commented Nov 20, 2021

Tested in the johngmyers/testactions repository.

Will tag an alpha to verify before removing the restriction to alpha. Then will backport script to release branches before enabling there.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 20, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 20, 2021
@johngmyers johngmyers force-pushed the tag-release branch 4 times, most recently from c6acab0 to bbe150e Compare November 20, 2021 23:53
@johngmyers johngmyers force-pushed the tag-release branch 2 times, most recently from 7e04e60 to 6a470fe Compare December 10, 2021 05:39
@johngmyers johngmyers changed the title WIP Add script for automatically tagging releases Add action for automatically tagging releases Dec 23, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 23, 2021
@johngmyers
Copy link
Member Author

/cc @justinsb @rifelpet


steps:
- uses: actions/checkout@v2
- run: /usr/bin/git config --global user.email actions@github.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there are any CLA concerns with having a commit in the repo authored from this email address. Are there other kubernetes repos that author git commits in GitHub Actions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's not authored by a human there are unlikely to be any legal concerns. The commit isn't going through a PR, so it won't trip up the CLA gates.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 1, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit ab4dcb6 into kubernetes:master Jan 1, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Jan 1, 2022
@johngmyers johngmyers deleted the tag-release branch January 1, 2022 18:22
k8s-ci-robot added a commit that referenced this pull request Jan 2, 2022
…2805-#13071-upstream-release-1.23

Automated cherry pick of #12805: Add action for automatically tagging releases #13071: Remove temporary restrictions on automatically tagging
k8s-ci-robot added a commit that referenced this pull request Jan 2, 2022
…2805-#13071-upstream-release-1.22

Automated cherry pick of #12805: Add action for automatically tagging releases #13071: Remove temporary restrictions on automatically tagging
k8s-ci-robot added a commit that referenced this pull request Jan 2, 2022
…2805-#13071-upstream-release-1.21

Automated cherry pick of #12805: Add action for automatically tagging releases #13071: Remove temporary restrictions on automatically tagging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants